Re-add py3.9 support to sage_autodoc.py #38619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the CI, I see: |
|
I should have double checked that an import of |
|
Documentation preview for this PR (built with commit 57f5d16; changes) is ready! 🎉 |
|
Looks a lot healthier now. |
|
This error still shows up with Python 3.9: |
|
Hopefully, I will not have to make those into blocks conditional to the version of python. And they will be enough. |
|
|
This does the trick, thanks very much! |
5 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9. Since we still want to support python 3.9, some support has to be re- introduced. See sagemath#38549 (comment) and after. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38619 Reported by: François Bissey Reviewer(s):
|
And it breaks sphinx-8. I will need to add some try expect blocks. Since it is being merged, that will be another follow up. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 8, 2024
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9. Since we still want to support python 3.9, some support has to be re- introduced. See sagemath#38549 (comment) and after. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38619 Reported by: François Bissey Reviewer(s):
|
@vbraun I see you have this in your merge tree, but it turns out it needs more work. Is it OK with you if I push some more commits or you'd prefer a follow up? |
|
you can keep working on it |
|
@mkoeppe if you would like to check that it is still working for you on py3.9. Unless you find something not working, it should be the last tweak. |
|
It works well with py3.9. LGTM. |
kwankyu
approved these changes
Sep 10, 2024
|
Thanks! |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 12, 2024
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9. Since we still want to support python 3.9, some support has to be re- introduced. See sagemath#38549 (comment) and after. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38619 Reported by: François Bissey Reviewer(s): Kwankyu Lee
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the fact the sage_autodoc.py changes needed for sphinx 8 dropped python 3.9 support. This is a consequence of the fact that sphinx 8 has dropped python 3.9.
Since we still want to support python 3.9, some support has to be re-introduced.
See #38549 (comment) and after.
📝 Checklist